Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove pydantic #189

Merged
merged 8 commits into from
Jul 10, 2023
Merged

fix: remove pydantic #189

merged 8 commits into from
Jul 10, 2023

Commits on Jul 10, 2023

  1. testing migrate to pydantic 2.0 

    where pydantic_settings is seperate package
    @lp9052 @maartenbreddels
    lp9052 authored and maartenbreddels committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    eb23efd View commit details
    Browse the repository at this point in the history

  2. use optional settings dependency

    @maartenbreddels
    maartenbreddels committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    20fd188 View commit details
    Browse the repository at this point in the history

  3. use ModuleNotFoundError

    @maartenbreddels
    maartenbreddels committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    9a9f124 View commit details
    Browse the repository at this point in the history

  4. require pydantic 2 on py > 3.6

    @maartenbreddels
    maartenbreddels committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    9122e31 View commit details
    Browse the repository at this point in the history

  5. fix: missing annotation for pydantic 2

    @maartenbreddels
    maartenbreddels committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    1588d78 View commit details
    Browse the repository at this point in the history

  6. feat: do not use pydantic 

    We only use pydantic for the settings, and it is not worth the
dependency. We made the API quite similar, but it is only for internal
use.

We cannot keep using pydantic because v2 does not include pydantic
settings code and needs the pydantic-settings dependency.
However, adding that dependency indirectly requires pydantic v2.
    @maartenbreddels
    maartenbreddels committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    f37ff83 View commit details
    Browse the repository at this point in the history

  7. ci: force use pydantic<2 for vaex dependency

    @maartenbreddels
    maartenbreddels committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    4037769 View commit details
    Browse the repository at this point in the history

  8. clean up

    @maartenbreddels
    maartenbreddels committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c898080 View commit details
    Browse the repository at this point in the history