fix: remove pydantic #189
Merged
fix: remove pydantic #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, this is not as simple as I hoped, see pydantic/pydantic#6497 Let's try to get of pydantic. We simply need an easy way to configure things, it shouldn't cause installation issues or breakage. |
maartenbreddels
force-pushed
the
migrate_to_pydantic_2.0
branch
from
1cc2b94
to
38a10ea
Compare
where pydantic_settings is seperate package
We only use pydantic for the settings, and it is not worth the dependency. We made the API quite similar, but it is only for internal use. We cannot keep using pydantic because v2 does not include pydantic settings code and needs the pydantic-settings dependency. However, adding that dependency indirectly requires pydantic v2.
maartenbreddels
force-pushed
the
migrate_to_pydantic_2.0
branch
from
a49f089
to
c898080
Compare
|
Thanks for starting this. In the end, we had to remove Pydantic, otherwise we'd have to choose between v1 and v2 and we don't want to do that for our users. |
|
Sorry for the delay, I was preparing my PhD application. It's unfortunate that we have to adopt this internally. Their decision to make a big change in a popular package is baffling. It's basically ineffective until everyone switches to pydantic2. I was dinged about our failing builds this morning, so I'm glad this was addressed. I truly appreciate it. |
|
Thank you for shipping this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing migrate to pydantic 2.0
where pydantic_settings is seperate package see #187
I quickly changed everything to pedantic_settings. But Solara depends on vaex which still error out.
I think for now we shall cap pedantic version. @maartenbreddels