Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Multi Uploader breaks when Upload fails #48

Merged
merged 5 commits into from
Nov 18, 2016
Merged

PR: Multi Uploader breaks when Upload fails #48

merged 5 commits into from
Nov 18, 2016

Conversation

kraftner
Copy link
Member

@kraftner kraftner commented Nov 4, 2016

fixes #36

@kraftner
Copy link
Member Author

kraftner commented Nov 4, 2016

This still lacks the built assets which is currently blocked by a broken build process. See #27

@franz-josef-kaiser franz-josef-kaiser added this to the 1.0.0 milestone Nov 16, 2016
@franz-josef-kaiser franz-josef-kaiser mentioned this pull request Nov 16, 2016
Open
@franz-josef-kaiser
Copy link
Member

franz-josef-kaiser commented Nov 16, 2016 •
edited
Loading

@kraftner After #27 is tested, issue-27-assets needs to get --no-ff merged into kraftner/issue/36 to proceed here.

franz-josef-kaiser pushed a commit to kraftner/wcm-avatar that referenced this pull request Nov 16, 2016
VCS: Merge issue-27-assets to enable asset building in PR wecodemore#48
ea73a4a
franz-josef-kaiser pushed a commit to kraftner/wcm-avatar that referenced this pull request Nov 16, 2016
Fix: Update assets, see wecodemore#48
cb702e0
@franz-josef-kaiser
Copy link
Member

@kraftner Did the update from issue-27-assets to the kraftner/issue/36 branch. Runs smoothly for me npm install && npm run build, but please double check with the goals for this PR. Thanks in advance!

@kraftner
Copy link
Member Author

Okay, I rebased this on dev and gave it a test run. I think everything should be ready for merge: 🎉

@franz-josef-kaiser franz-josef-kaiser merged commit 4182c2c into wecodemore:dev Nov 18, 2016
@franz-josef-kaiser
Copy link
Member

On Friday nights, I blindly trust you @kraeftner

@kraftner kraftner mentioned this pull request Nov 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kraftner kraftner

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kraftner @franz-josef-kaiser