Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As developer I want to have a complete build during installation #27

Open
franz-josef-kaiser opened this issue Oct 22, 2016 · 5 comments
Assignees
Milestone

Comments

@franz-josef-kaiser
Copy link
Member

Currently we have a Git hook to run the NPM build process, which then uses bash scripts to call the proper commands. We also have a .po-file generator that sits in the root. All this should better be summoned and run during a Composer install script as this is when the package gets pulled and set up. In addition, we should continue to ship the assets in minified versions to have a fallback.

@kraftner
Copy link
Member

kraftner commented Nov 4, 2016

I think the whole build process is broken:

package.json#L17 and scripts/scripts don't match.
After that it still doesn't work because something is wrong with scripts/scripts#L2

Also the versions used look old and I'm note sure of the packages themselves.

So yeah, this all needs a major overhaul. 😄

@franz-josef-kaiser
Copy link
Member Author

franz-josef-kaiser commented Nov 5, 2016

@kraftner should be working again. Use npm run build to trigger a build. I am not really sure if the watch process works. The last version used to just call npm run build, which triggered endlessly. The current version just includes the commands from the js and the css files. While this might work better, the file location is relative to the location from where you call the script – it just assumes you are in the project root when doing so. This might fail, please give this a test run. The branch to test is issue-27-assets.

@kraftner
Copy link
Member

kraftner commented Nov 16, 2016

Yeah, works again. I also noticed that as it seems up until now there was a mismatch between src and concat/minified files like e.g. models.js and all.js

I'll add a rebuild of the assets to the issue branch and merge this tomorrow.

@franz-josef-kaiser
Copy link
Member Author

Thanks @kraftner – Please do not forget about #48

kraftner pushed a commit to kraftner/wcm-avatar that referenced this issue Nov 18, 2016
kraftner pushed a commit to kraftner/wcm-avatar that referenced this issue Nov 18, 2016
kraftner pushed a commit to kraftner/wcm-avatar that referenced this issue Nov 18, 2016
@kraftner
Copy link
Member

@franz-josef-kaiser Is this good enough in your opinion or do you want to keep it open to further improve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants