-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As developer I want to have a complete build during installation #27
Comments
I think the whole build process is broken: package.json#L17 and scripts/scripts don't match. Also the versions used look old and I'm note sure of the packages themselves. So yeah, this all needs a major overhaul. 😄 |
@kraftner should be working again. Use |
@franz-josef-kaiser Is this good enough in your opinion or do you want to keep it open to further improve it? |
Currently we have a Git hook to run the NPM build process, which then uses bash scripts to call the proper commands. We also have a
.po
-file generator that sits in the root. All this should better be summoned and run during a Composer install script as this is when the package gets pulled and set up. In addition, we should continue to ship the assets in minified versions to have a fallback.The text was updated successfully, but these errors were encountered: