Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve photo album pages #5128

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Improve photo album pages #5128

merged 7 commits into from
Nov 6, 2024

Commits on Oct 30, 2024

  1. Improve gallery picture modal loading

    @eikhr
    eikhr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3454aba View commit details
    Browse the repository at this point in the history

  2. Replace image gallery ProgressiveImage component with the normal Imag… 

    …e component
    @eikhr
    eikhr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b55d0cd View commit details
    Browse the repository at this point in the history

  3. Make image gallery modals into sub-pages of the gallery detail page 

    This preserves scroll location in the gallery detail page when opening
and closing images
    @eikhr
    eikhr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6ef4be3 View commit details
    Browse the repository at this point in the history

  4. Make gallery picture edit form a child page of gallery picture modal

    @eikhr
    eikhr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ca6094f View commit details
    Browse the repository at this point in the history

  5. Force constant height of image in photo album modal

    @eikhr
    eikhr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3dbc17b View commit details
    Browse the repository at this point in the history

  6. Fix issue where closing a modal clicks the element behind the close b… 

    …utton
    @eikhr
    eikhr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    60739b5 View commit details
    Browse the repository at this point in the history

  7. Make photo album modal dismissable 

    This required adding a ref to the modal and making the dropdown use this
ref as the container. It previously used document.body as the container,
meaning any clicks in the dropdown were counted as outside the modal and
closed the modal.
    @eikhr
    eikhr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6a45535 View commit details
    Browse the repository at this point in the history