Improve photo album pages #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preserves scroll location in the gallery detail page when opening and closing images
eikhr
requested review from
webkom-R2D2,
itsisak,
falbru,
ivarnakken and
christiangryt
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This required adding a ref to the modal and making the dropdown use this ref as the container. It previously used document.body as the container, meaning any clicks in the dropdown were counted as outside the modal and closed the modal.
eikhr
force-pushed
the
improve-photo-gallery
branch
from
eaba04b
to
6a45535
Compare
jonasdeluna
approved these changes
Oct 30, 2024
ivarnakken
approved these changes
Oct 31, 2024
| @@ -1,14 +1,27 @@ | |||
| @import url('~app/styles/variables.css'); | |||
|
|
|||
| .loadingIndicator { | |||
| margin: 0.375rem; | |||
There was a problem hiding this comment.
It should match the padding of clickable Icons: https://github.com/webkom/lego-webapp/blame/8d156d0615da926ca9b2d0cc12037576fa4bc223/packages/lego-bricks/src/components/Icon/Icon.module.css#L24
There was a problem hiding this comment.
It avoids a slight movement in the layout, which doesn't look great.
| @@ -22,6 +35,9 @@ | |||
| } | |||
|
|
|||
| .dropdown { | |||
| position: absolute; | |||
| top: 0; | |||
| right: 3rem; | |||
There was a problem hiding this comment.
How should we position this? I personally think the current position looks a bit off.
The close-button in the modal is also absolute-positioned, so I don't think there is any other easy way to get the correct positioning.
|
It look so much nicer! |
falbru
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The image gallery was a bit clunky and had some bugs.
The following issues are fixed in this PR:
ProgressiveImagecomponentShould be tested to really feel the improvements.
Result
The above issues are fixed. Minor visual changes.
It now has a lot less duplicated code, though.
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-1159