Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove horizontal table scroll #4976

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

Bestem0r
Copy link
Contributor

Description

This has annoyed me for quite a while, especially when working on the updated BDB. This PR hides the horizontal scroll bar in the Table component when it's not needed. The bar will still appear if the content becomes scrollable.

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Before After
Screenshot from 2024-09-22 22-15-08 Screenshot from 2024-09-22 22-15-28

Testing

  • I have thoroughly tested my changes.

Verify that the horizontal scroll bar is hidden in all tables when the content is not horizontally scrollable.

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Sep 22, 2024 8:16pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Sep 22, 2024
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Is this a Firefox thing or something? Haven't noticed

@Bestem0r
Copy link
Contributor Author

Nice fix! Is this a Firefox thing or something? Haven't noticed

Happens to me in chrome on Linux 🤔

@Bestem0r Bestem0r merged commit e7e0f6c into master Sep 23, 2024
6 checks passed
@Bestem0r Bestem0r deleted the remove-horizontal-table-scroll branch September 23, 2024 10:46
@Bestem0r Bestem0r mentioned this pull request Oct 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants