Update company design #4995
Merged
Update company design #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bestem0r
requested review from
eikhr,
itsisak,
falbru,
juniwbjerde,
ivarnakken and
ShaileshS1702
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eikhr
reviewed
Sep 25, 2024
eikhr
reviewed
Sep 25, 2024
eikhr
reviewed
Sep 25, 2024
ivarnakken
reviewed
Sep 26, 2024
Comment on lines
+10
to
+12
| .overflowWrap { | ||
| overflow-wrap: anywhere; | ||
| } |
There was a problem hiding this comment.
This feels dangerous. Have you checked how this affects other uses of the component? Like on the event detail page
There was a problem hiding this comment.
Yeah, I quickly checked through all uses now and couldn't spot any problems
Fixed in this PR |
|
Can you rereview? @ivarnakken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the company details page in BDB to use the new table components, and applies a more modern and compact design. Feel free to suggest design changes if you have any! 😄
Result
Before:
Screencast.from.2024-09-22.19-41-43.webm
After:
Screencast.from.2024-09-22.19-38-55.webm
Testing
Resolves ABA-1054