-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify event detail page by moving stuff into components #4974
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
66408bc
to
f6bb350
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot cleaner than before:) lgtm!
const MIN_USER_GRID_ROWS = 2; | ||
const MAX_USER_GRID_ROWS = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels unnecessary, but ok
f6bb350
to
e5bc9d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Description
Moved stuff out of event detail page, into separate components. Fixes a bunch of typescript errors too
Result
No visual changes
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.