Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify event detail page by moving stuff into components #4974

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Sep 22, 2024

Description

Moved stuff out of event detail page, into separate components. Fixes a bunch of typescript errors too

Result

No visual changes

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 9:32pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Sep 22, 2024
@eikhr eikhr mentioned this pull request Sep 22, 2024
4 tasks
Copy link
Member

@juniwbjerde juniwbjerde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot cleaner than before:) lgtm!

Comment on lines +15 to +16
const MIN_USER_GRID_ROWS = 2;
const MAX_USER_GRID_ROWS = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels unnecessary, but ok

Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@eikhr eikhr merged commit d5fa89d into master Sep 23, 2024
6 checks passed
@eikhr eikhr deleted the simplify-event-detail branch September 23, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants