Refactor and fix types in event pages #4973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eikhr
force-pushed
the
refactor-events
branch
from
6242e0c
to
5d0ac6c
Compare
Also fix issues in createLegoAdapter causing type errors
eikhr
force-pushed
the
refactor-events
branch
from
5d0ac6c
to
24222e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Appearantly this PR was "too large" and had "too many changes to review", so I will split it up a bit. The first part is here #4974
Description
While working on ABA-1070 I got a bit annoyed at how much spaghetti and type errors there was. So i did some refactoring:)
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
No visual changes.
Fixes the loading indicator when unregistering people in the admin list.
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.