Report unmapped non-deprecated, standard keys #2222
Merged
+79
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tools and infrastructure
This adds a few things to the `stats` script: - a `compatKeysUnmapped` count - a `--verbose` flag, to get the list of `toBeMapped` keys - an export, so I can use this script's output to generate part of the releases (to come later) Built atop web-platform-dx#2211
ddbeck
force-pushed
the
burndown-inline
branch
from
bd817ab
to
f8e36c2
Compare
Elchi3
reviewed
Nov 13, 2024
scripts/stats.ts
Outdated
| const result = { | ||
| features: featureCount, | ||
| compatKeys: doneKeys.length, | ||
| compatKeysUnmapped: toDoKeys.length, |
There was a problem hiding this comment.
So, there are two numbers for unmapped keys here:
(1) toDoKeys.length
(2) toDoKeys.length + deprecatedNonStandardKeys.length
The current compatCoverage percentage takes into account (2) but compatKeysUnmapped doesn't. I think this is a bit confusing.
Maybe we want to expose something like this?
currentBurndown: toDoKeys.length
compatKeysUnmapped: toDoKeys.length + deprecatedNonStandardKeys.length
There was a problem hiding this comment.
Yes, this is a good idea. I've changed this a bit based on your comment:
compatKeysis what we have in the feature datacompatKeysUnmappedistoDoKeys.length + deprecatedNonStandardKeys.lengthcurrentBurndownSizeis the number of standard, non-deprecated keys left to mapcurrentBurndownis the array of standard, non-deprecated keys left to map
Elchi3
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few things to the
statsscript:compatKeysUnmappedcountcurrentBurndownSizecount (standard, non-deprecated keys to go)--verboseflag, to get the list ofcurrentBurndownkeysIf you want only the burndown list, then
npx tsx ./scripts/stats.ts --verbose | jq --raw-output '.currentBurndown[]'pretty prints it (that probably deserves an entry innpm run, honestly).Built atop #2211.