Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(draft) List of unmapped non-deprecated keys #2211

Closed
wants to merge 1 commit into from

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Nov 12, 2024

Draft code, just for inspiration for @ddbeck and @jamesnw.

npx tsx scripts/stats.ts gives you a list of unmapped and non-deprecated keys. (I hope)

Please take this and turn it into a useful command so we can all burndown the remaining 3000 keys efficiently :)

@github-actions github-actions bot added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Nov 12, 2024
@jamesnw
Copy link
Collaborator

jamesnw commented Nov 12, 2024

Thanks for this! Very helpful.

One question this brought up for me is around prefixed keys. This list includes prefixed properties with their own files, for instance css.properties.-webkit-line-snap. It does not include prefixed properties that are specified in the __compat section of a file. For instance css.properties.line-clamp, in Firefox, it has a prefix -webkit, but css.properties.-webkit-line-clamp doesn't exist.

My assumption is that the prefixed properties are not actually standard track (outside of the Compat standard), and should be marked as standard_track: false, which would remove them from this list (and the need to include them from Web Features. Is that correct?

@Elchi3
Copy link
Collaborator Author

Elchi3 commented Nov 12, 2024

Thanks James, very interesting, so I think the filtering should be !f.deprecated && f.standard_track, which is not what I have in this PR. Another reason to land a command that gets all of us the same burndown list :)

ddbeck added a commit to ddbeck/web-features that referenced this pull request Nov 13, 2024
This adds a few things to the `stats` script:

- a `compatKeysUnmapped` count
- a `--verbose` flag, to get the list of `toBeMapped` keys
- an export, so I can use this script's output to generate part of the
  releases (to come later)

Built atop web-platform-dx#2211
ddbeck added a commit to ddbeck/web-features that referenced this pull request Nov 13, 2024
This adds a few things to the `stats` script:

- a `compatKeysUnmapped` count
- a `--verbose` flag, to get the list of `toBeMapped` keys
- an export, so I can use this script's output to generate part of the
  releases (to come later)

Built atop web-platform-dx#2211
ddbeck added a commit to ddbeck/web-features that referenced this pull request Nov 13, 2024
This adds a few things to the `stats` script:

- a `compatKeysUnmapped` count
- a `--verbose` flag, to get the list of `toBeMapped` keys
- an export, so I can use this script's output to generate part of the
  releases (to come later)

Built atop web-platform-dx#2211
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 13, 2024

Thanks for opening this, Florian! I opened the sequel that builds on top of this: #2222.

@Elchi3 Elchi3 closed this Nov 13, 2024
@Elchi3 Elchi3 deleted the draft branch November 13, 2024 11:31
Elchi3 added a commit that referenced this pull request Nov 13, 2024
* (draft) List of unmapped non-deprecated keys

* Report unmapped non-deprecated, standard keys

This adds a few things to the `stats` script:

- a `compatKeysUnmapped` count
- a `--verbose` flag, to get the list of `toBeMapped` keys
- an export, so I can use this script's output to generate part of the
  releases (to come later)

Built atop #2211

* Reconcile coverage and unmapped key count

---------

Co-authored-by: Florian Scholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants