Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include exception message in JSON error result #305

Closed
wants to merge 1 commit into from
Closed

Do not include exception message in JSON error result #305

wants to merge 1 commit into from

Commits on Dec 6, 2023

  1. Removed unreferenced parameter name 

    Signed-off-by: Lauris Kaplinski <[email protected]> (+6 squashed commits)
Squashed commits:
[6fb95c8] Fixed catch parameter

Signed-off-by: Lauris Kaplinski <[email protected]>
[0b6f274] Added missed file

Signed-off-by: Lauris Kaplinski <[email protected]>
[11be5f6] Fixed already caught exception issue, updated vcpkgGitCommitId and added some comments

Signed-off-by: Lauris Kaplinski <[email protected]>
[9cec528] Catch all exeptions that contain APDU code in message separately and ensure that it is not leaked to app output

Signed-off-by: Lauris Kaplinski <[email protected]>
[ab43ab3] Fixed a typo

Signed-off-by: Lauris Kaplinski <[email protected]>
[a16c4fd] Do not include actual exception message in result, use generic message instead.
Fixes potential leak of sensitive information as some card exceptions in libpcsc-cpp include expected/actual APDU response

Signed-off-by: Lauris Kaplinski <[email protected]>
    Lauris Kaplinski committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b4f8032 View commit details
    Browse the repository at this point in the history