Do not include exception message in JSON error result #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lauris Kaplinski <[email protected]> (+6 squashed commits) Squashed commits: [6fb95c8] Fixed catch parameter Signed-off-by: Lauris Kaplinski <[email protected]> [0b6f274] Added missed file Signed-off-by: Lauris Kaplinski <[email protected]> [11be5f6] Fixed already caught exception issue, updated vcpkgGitCommitId and added some comments Signed-off-by: Lauris Kaplinski <[email protected]> [9cec528] Catch all exeptions that contain APDU code in message separately and ensure that it is not leaked to app output Signed-off-by: Lauris Kaplinski <[email protected]> [ab43ab3] Fixed a typo Signed-off-by: Lauris Kaplinski <[email protected]> [a16c4fd] Do not include actual exception message in result, use generic message instead. Fixes potential leak of sensitive information as some card exceptions in libpcsc-cpp include expected/actual APDU response Signed-off-by: Lauris Kaplinski <[email protected]>
metsma
approved these changes
Dec 6, 2023
|
Closing in favor of #316. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We2 556
Certain libpcsc exceptions contain actual transmitted or expected APDU in message. Passing these to webextension creates a potential risk of leaking sensitive data.
Signed-off-by: Lauris Kaplinski [email protected]