Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move iceServers limit to setConfiguration steps. #2890

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Move iceServers limit to setConfiguration steps. #2890

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e092ba
Move iceServers limit to setConfiguration steps.
jan-ivar Aug 15, 2023
8fb8bfa
Add test annotation.
jan-ivar Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,13 +1277,6 @@ <h4>
checks are unnecessary.
</p>
</li>
<li data-tests="RTCConfiguration-iceServers.html">
<p>
If
<var>configuration</var>.{{RTCConfiguration/iceServer}} is an array
truncate it to the maximum number of supported elements.
</p>
</li>
<li>
<p>
Initialize <var>connection</var>'s [= ICE Agent =].
Expand Down Expand Up @@ -3045,10 +3038,21 @@ <h4>
</li>
</ol>
</li>
<li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the data-tests tag follow along?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm landing that test in https://phabricator.services.mozilla.com/D186256 today, so I might as well add it now. Thanks!

<p>
Let <var>iceServers</var> be
<var>configuration</var>.{{RTCConfiguration/iceServers}}.
</p>
</li>
<li>
<p>
Truncate <var>iceServers</var> to the maximum number of supported elements.
</p>
</li>
<li data-tests="RTCConfiguration-iceServers.html">
<p id="config-iceservers">
For each <var>server</var> in
<var>configuration</var>.{{RTCConfiguration/iceServers}},
<var>iceServers</var>,
run the following steps:
</p>
<ol>
Expand Down Expand Up @@ -3164,7 +3168,7 @@ <h4>
<p>
Set the [= ICE Agent =]'s <dfn id="ice-servers-list">ICE
servers list</dfn> to
<var>configuration</var>.{{RTCConfiguration/iceServers}}.
<var>iceServers</var>.
</p>
<p>
As defined in <span data-jsep=
Expand Down
Loading