Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move iceServers limit to setConfiguration steps. #2890

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Aug 15, 2023

Fixes #2889.


Preview | Diff

@jan-ivar jan-ivar self-assigned this Aug 15, 2023
webrtc.html Outdated
@@ -3045,10 +3038,21 @@ <h4>
</li>
</ol>
</li>
<li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the data-tests tag follow along?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm landing that test in https://phabricator.services.mozilla.com/D186256 today, so I might as well add it now. Thanks!

@alvestrand alvestrand merged commit 3bca514 into w3c:main Aug 17, 2023
2 of 3 checks passed
@jan-ivar jan-ivar deleted the iceserversfix branch August 17, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editorial mistakes in iceServers limit
3 participants