Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination of API requests #128

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions plugins/doc_fragments/vultr_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ class ModuleDocFragment(object):
- Fallback environment variable C(VULTR_API_RETRY_MAX_DELAY).
type: int
default: 12
api_results_per_page:
description:
- When receiving large numbers of resources, specify how many results should be returned per call to API.
- This does not determine how many results are returned; all resources are returned according to other filters.
- Vultr API maximum is 500.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this maximum per page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

- Fallback environment variable C(VULTR_API_RESULTS_PER_PAGE).
type: int
default: 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want this in the next release, so you may add the version, when it is going to be added

  default: 100
+ version_added: 1.14.0

api_endpoint:
description:
- URL to API endpint (without trailing slash).
Expand Down
53 changes: 48 additions & 5 deletions plugins/module_utils/vultr_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

from ansible.module_utils._text import to_text
from ansible.module_utils.basic import env_fallback
from ansible.module_utils.common.dict_transformations import dict_merge
from ansible.module_utils.six.moves.urllib.parse import quote
from ansible.module_utils.urls import fetch_url

Expand Down Expand Up @@ -45,6 +46,11 @@ def vultr_argument_spec():
fallback=(env_fallback, ["VULTR_API_RETRY_MAX_DELAY"]),
default=12,
),
api_results_per_page=dict(
type="int",
fallback=(env_fallback, ["VULTR_API_RESULTS_PER_PAGE"]),
default=100,
),
validate_certs=dict(
type="bool",
default=True,
Expand Down Expand Up @@ -113,6 +119,7 @@ def __init__(
"api_timeout": module.params["api_timeout"],
"api_retries": module.params["api_retries"],
"api_retry_max_delay": module.params["api_retry_max_delay"],
"api_results_per_page": module.params["api_results_per_page"],
"api_endpoint": module.params["api_endpoint"],
},
}
Expand All @@ -135,6 +142,35 @@ def transform_resource(self, resource):
"""
return resource

def paginate_api_query(self, path, method="GET", data=None, query_params=None, result_key=None):
result_key = result_key or self.ressource_result_key_plural
pager_param = dict(per_page=self.module.params["api_results_per_page"])
if query_params is not None:
query_params = dict_merge(query_params, pager_param)
else:
query_params = pager_param

result = dict()
cursor = dict()
while True:
resp = self.api_query(
path=path,
method=method,
data=data,
query_params=dict_merge(query_params, cursor),
)

resp_body = resp.get(result_key, {})
if isinstance(resp_body, list):
if isinstance(result.get(result_key), list):
result[result_key].extend(resp_body)
else:
result[result_key] = resp_body
cursor["cursor"] = resp.get("meta", {}).get("links", {}).get("next", "")

if cursor["cursor"] == "":
return result

def api_query(self, path, method="GET", data=None, query_params=None):
if query_params:
query = "?"
Expand All @@ -151,12 +187,12 @@ def api_query(self, path, method="GET", data=None, query_params=None):
resp_body = None
for retry in range(0, self.module.params["api_retries"]):
resp, info = fetch_url(
self.module,
self.module.params["api_endpoint"] + path,
module=self.module,
url=self.module.params["api_endpoint"] + path,
method=method,
data=data,
headers=self.headers,
timeout=self.module.params["api_timeout"],
timeout=int(self.module.params["api_timeout"]),
)

resp_body = resp.read() if resp is not None else ""
Expand Down Expand Up @@ -254,7 +290,10 @@ def query_by_id(self, resource_id=None, path=None, result_key=None, skip_transfo
path = path or self.resource_path
result_key = result_key or self.ressource_result_key_singular

resource = self.api_query(path="%s%s" % (path, "/" + resource_id if resource_id else resource_id))
resource = self.api_query(
path="%s%s" % (path, "/" + resource_id if resource_id else resource_id)
)

if resource:
if skip_transform:
return resource[result_key]
Expand All @@ -272,7 +311,11 @@ def query_list(self, path=None, result_key=None, query_params=None):
path = path or self.resource_path
result_key = result_key or self.ressource_result_key_plural

resources = self.api_query(path=path, query_params=query_params)
resources = self.paginate_api_query(
path=path,
query_params=query_params,
result_key=result_key,
)
return resources[result_key] if resources else []

def wait_for_state(self, resource, key, states, cmp="=", retries=60, skip_wait=False):
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/account_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/bare_metal.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/block_storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/block_storage_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/dns_domain.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/dns_domain_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/dns_record.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/firewall_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/firewall_group_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/firewall_rule.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/firewall_rule_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/instance_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/object_storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/object_storage_cluster_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/object_storage_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/os_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/plan_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/plan_metal_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/region_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/reserved_ip.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/snapshot.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/snapshot_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@
returned: success
type: int
sample: 12
api_results_per_page:
description: Number of results returned per call to API.
returned: success
type: int
sample: 100
api_endpoint:
description: Endpoint used for the API requests.
returned: success
Expand Down
Loading