Pagination of API requests #128
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resmo
reviewed
Jul 29, 2024
| description: | ||
| - When receiving large numbers of resources, specify how many results should be returned per call to API. | ||
| - This does not determine how many results are returned; all resources are returned according to other filters. | ||
| - Vultr API maximum is 500. |
resmo
reviewed
Jul 30, 2024
| - Vultr API maximum is 500. | ||
| - Fallback environment variable C(VULTR_API_RESULTS_PER_PAGE). | ||
| type: int | ||
| default: 100 |
There was a problem hiding this comment.
we want this in the next release, so you may add the version, when it is going to be added
default: 100
+ version_added: 1.14.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a wrapper around vultr_v2.api_query that handles pagination
Related Issues
Fixes #127
Checklist:
@resmo : I'm going to run the integration tests against my account and verify everything works there, but review / feedback is greatly appreciated, since I haven't had a chance to verify the behavior with all services yet and the different vultr_v2.query* functions.