Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address lints from nightly #121

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Mar 4, 2024

tested with cargo 1.78.0-nightly (f772ec022 2024-03-01)

Brian Caswell added 2 commits March 4, 2024 17:20
tested with cargo 1.78.0-nightly (f772ec022 2024-03-01)
@demoray
Copy link
Contributor Author

demoray commented Mar 4, 2024

Personally, I don't track nightly. This PR is to address builds failing due to the coverage task being built on nightly.

@vthib
Copy link
Owner

vthib commented Mar 4, 2024

Ah yes, I use nightly for the coverage to be able to use the #[coverage(off)] directive, which is unstable. There are some activity on the tracking issue, so hopefully it will get stabilized at some point.

The issue is that I have RUSTFLAGS=-Dwarnings set on top of the github actions, so it gets picked up by all jobs. Ideally, this job should not use it, and thus those warnings would not cause the coverage job to fail.

Also, you fixed clippy lints but you didn't really have to, we only do cargo test on nightly.

Thanks for the PR!

@vthib vthib merged commit 01b54a7 into vthib:master Mar 4, 2024
12 checks passed
@demoray demoray deleted the address-lints-from-nightly branch March 5, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants