Calculate independent FMSs for each symbol message (fixes #15) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c doctests, and add layer parameter to all scripts
…allow for simpler subtype checks
* release: finish NEMETYL development, INFOCOM2020 paper release massive code cleanup, refactor AbstractSegment and its type hints to allow for simpler subtype checks initate NEMETYL development README update: compatibility compatibility to tshark 2.6.3 json output
* pin versions * sort requirements.txt * Remove netzob, install manually instead * Add Dockerfile * rename workdir to nemere * Pin netzob commit * Install pylstar manually pylstar is a dependency of netzob, but pip refuses to install it. Therefore, we are just installing it manually befor installing netzob.
WIP: Minor fixes
fix failing doctests
remove namespace cluttering imports in nemere/__init__.py
add some debug output per logger
handle smb's NT IOCTL Data
fix performance in getting tshark-version-compatible ParsingConstants
fix typos
fix parallel dissimilarity calculation
fix minor doctest issues
small fixes in main scripts
add details in comments
fix failing doctests remove namespace cluttering imports in nemere/__init__.py add some debug output per logger handle smb's NT IOCTL Data fix performance in getting tshark-version-compatible ParsingConstants fix typos fix parallel dissimilarity calculation fix minor doctest issues small fixes in main scripts add details in comments
* release: Squashed commit of the following:
This shall overrided the version used by netzob which is deprecated and results in python warnings because of old code.
_getElementByName always returns a list now
Typos and docu
simplify if-cascade in ParsedMessage._parseJSON
add test cases for messageParser/ParsedMessage._getElementByName
fix doctests to be called by nosetests
added dns field for type lookup (by Mathias Wagner)
symbolListFMS did only calculate FMS for one message, instead of all message of a symbol. Now it is create a DissectorMatcher object for each message of the symbol and thus creates a FMS list of all message of a symbol.
|
You (accidently) removed the WatchdogTimeout try-catch block that prevents a (almost) indefinite runtime for Symbols that Netzob essentially fails in parsing. Granted, this watchdog is a crude workaround, but still necessary in my eyes. Could you readd this in your PR? |
skleber
requested changes
Jun 24, 2022
|
Having a second look, it noticed, its not that easy, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symbolListFMS did only calculate FMS for one message, instead of all
message of a symbol. Now it is create a DissectorMatcher object for each
message of the symbol and thus creates a FMS list of all message of
a symbol.
As far as I can see, the TODO is already mentioning the problem I ran into: the code as it is does only add one message, not all. I cleaned it up. I think it is working as intended now. Or am I missing anything here? Works for me so far :) and for
netzob_fms.pyandnemesys_fms.pyas far as I can see...Would fix #15