Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more native rspec matchers in tests #179

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Use more native rspec matchers in tests #179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45766af
Consistently use the be_a Hash assertion
ekohl Jun 9, 2024
907fdf9
Use contain_exactly to assert results
ekohl Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 47 additions & 92 deletions spec/rspec_puppet_facts_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,26 +209,22 @@
is_expected.to be_a Hash
end

it 'has 5 elements' do
expect(subject.size).to eq 5
end

it 'returns supported OS' do
expect(subject.keys.sort).to eq %w(
debian-11-x86_64
debian-12-x86_64
redhat-7-x86_64
redhat-8-x86_64
redhat-9-x86_64
expect(subject.keys).to contain_exactly(
'debian-11-x86_64',
'debian-12-x86_64',
'redhat-7-x86_64',
'redhat-8-x86_64',
'redhat-9-x86_64',
)
end

it 'is able to filter the received OS facts' do
allow(described_class).to receive(:spec_facts_os_filter).and_return('redhat')
expect(subject.keys.sort).to eq %w(
redhat-7-x86_64
redhat-8-x86_64
redhat-9-x86_64
expect(subject.keys).to contain_exactly(
'redhat-7-x86_64',
'redhat-8-x86_64',
'redhat-9-x86_64',
)
end
end
Expand Down Expand Up @@ -288,24 +284,20 @@
is_expected.to be_a Hash
end

it 'has 4 elements' do
expect(subject.size).to eq 4
end

it 'returns supported OS' do
expect(subject.keys.sort).to eq %w(
debian-11-x86_64
debian-12-x86_64
redhat-8-x86_64
redhat-9-x86_64
expect(subject.keys).to contain_exactly(
'debian-11-x86_64',
'debian-12-x86_64',
'redhat-8-x86_64',
'redhat-9-x86_64',
)
end

it 'is able to filter the received OS facts' do
allow(described_class).to receive(:spec_facts_os_filter).and_return('redhat')
expect(subject.keys.sort).to eq %w(
redhat-8-x86_64
redhat-9-x86_64
expect(subject.keys).to contain_exactly(
'redhat-8-x86_64',
'redhat-9-x86_64',
)
end
end
Expand All @@ -325,12 +317,8 @@
expect(factsets).to be_a(Hash)
end

it 'returns a single fact set' do
expect(factsets.size).to eq(1)
end

it 'returns a fact set for the specified release' do
expect(factsets).to include('redhat-9-x86_64' => include(:operatingsystemmajrelease => '9'))
expect(factsets).to match('redhat-9-x86_64' => include(:operatingsystemmajrelease => '9'))
end
end

Expand All @@ -352,20 +340,16 @@
)
}

let(:expected_fact_sets) do
['ubuntu-18.04-x86_64', 'ubuntu-20.04-x86_64', 'ubuntu-22.04-x86_64']
end

it 'returns a hash' do
expect(subject.class).to eq Hash
end

it 'has 3 elements' do
expect(subject.size).to eq(expected_fact_sets.size)
expect(subject).to be_a Hash
end

it 'returns supported OS' do
expect(subject.keys.sort).to eq(expected_fact_sets)
expect(subject.keys).to contain_exactly(
'ubuntu-18.04-x86_64',
'ubuntu-20.04-x86_64',
'ubuntu-22.04-x86_64',
)
end
end

Expand All @@ -387,17 +371,13 @@
}

it 'returns a hash' do
expect(subject.class).to eq Hash
end

it 'has 1 elements' do
expect(subject.size).to eq 1
expect(subject).to be_a Hash
end

it 'returns supported OS' do
expect(subject.keys.sort).to eq [
expect(subject.keys).to contain_exactly(
'freebsd-13-amd64',
]
)
end
end

Expand All @@ -419,17 +399,13 @@
}

it 'returns a hash' do
expect(subject.class).to eq Hash
end

it 'has 1 elements' do
expect(subject.size).to eq 1
expect(subject).to be_a Hash
end

it 'returns supported OS' do
expect(subject.keys.sort).to eq [
expect(subject.keys).to contain_exactly(
'openbsd-7-amd64',
]
)
end
end

Expand All @@ -451,17 +427,14 @@
}

it 'returns a hash' do
expect(subject.class).to eq Hash
end

it 'has 1 elements' do
pending('2024-06-07: we dont have a suitable solaris 11 factset in facterdb')
expect(subject.size).to eq 1
expect(subject).to be_a Hash
end

it 'returns supported OS' do
pending('2024-06-07: we dont have a suitable solaris 11 factset in facterdb')
expect(subject.keys.sort).to eq %w(solaris-11-sun4v)
expect(subject.keys).to contain_exactly(
'solaris-11-i86pc',
)
end
end

Expand All @@ -483,19 +456,16 @@
}

it 'returns a hash' do
expect(subject.class).to eq Hash
end

it 'has 1 elements' do
pending('2024-06-07: we dont have a suitable AIX factset in facterdb')
expect(subject.size).to eq 1
expect(subject).to be_a Hash
end

it 'returns supported OS' do
# NOTE: See FACT-1827 for details on the IBM,8284-22A part
# That has to match whatever hardware generated the facts file.
pending('2024-06-07: we dont have a suitable solaris 11 factset in facterdb')
expect(subject.keys.sort).to eq %w(aix-7100-IBM,8284-22A)
expect(subject.keys).to contain_exactly(
'aix-7100-IBM,8284-22A',
)
end
end

Expand All @@ -520,32 +490,28 @@
let(:release) { ['10'] }

it { is_expected.to be_a(Hash) }
it { is_expected.to have_attributes(:size => 1) }
it { is_expected.to include('windows-10-x86_64' => an_instance_of(Hash)) }
it { is_expected.to match('windows-10-x86_64' => an_instance_of(Hash)) }
end

context 'with a revision release' do
let(:release) { ['2012 R2'] }

it { is_expected.to be_a(Hash) }
it { is_expected.to have_attributes(:size => 1) }
it { is_expected.to include('windows-2012 R2-x86_64' => an_instance_of(Hash)) }
it { is_expected.to match('windows-2012 R2-x86_64' => an_instance_of(Hash)) }
end

context 'with a Server prefixed release' do
let(:release) { ['Server 2012'] }

it { is_expected.to be_a(Hash) }
it { is_expected.to have_attributes(:size => 1) }
it { is_expected.to include('windows-2012-x86_64' => an_instance_of(Hash)) }
it { is_expected.to match('windows-2012-x86_64' => an_instance_of(Hash)) }
end

context 'with a 2016 release' do
let(:release) { ['2016'] }

it { is_expected.to be_a(Hash) }
it { is_expected.to have_attributes(:size => 1) }
it { is_expected.to include('windows-2016-x86_64' => an_instance_of(Hash)) }
it { is_expected.to match('windows-2016-x86_64' => an_instance_of(Hash)) }
end
end

Expand All @@ -566,19 +532,12 @@
}

it 'returns a hash' do
expect(subject.class).to eq Hash
end

it 'has 1 elements' do
pending('2024-06-7: facterdb has no factset with space in the system release')
expect(subject.size).to eq 1
expect(subject).to be_a Hash
end

it 'returns supported OS' do
pending('2024-06-7: facterdb has no factset with space in the system release')
expect(subject.keys.sort).to eq [
'sles-11-x86_64',
]
expect(subject.keys).to contain_exactly('sles-11-x86_64')
end
end

Expand Down Expand Up @@ -625,15 +584,11 @@
}

it 'returns a hash' do
expect(subject.class).to eq Hash
end

it 'has 2 elements' do
expect(subject.size).to eq 2
expect(subject).to be_a Hash
end

it 'returns supported OS' do
expect(subject.keys.sort).to include(a_string_matching(/\Agentoo-\d+-x86_64/), 'debian-12-x86_64')
expect(subject.keys).to contain_exactly(a_string_matching(/\gentoo-\d+-x86_64/), 'debian-12-x86_64')
end
end

Expand Down