Use more native rspec matchers in tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more native way of asserting it's a certain class.
This is a more native way to assert results, meaning asserting the size is redundant.
bastelfreak
force-pushed
the
more-native-matchers
branch
from
cdeac2d
to
907fdf9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 2 2
Lines 161 161
=======================================
Hits 153 153
Misses 8 8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
be_aandcontain_exactlythe tests are more expressive and rspec is better able to tell you what doesn't match. It also removes the (now redundant) size checks on results, givencontain_exactlyalready gives that guarantee.