Require FacterDB 2.x #176
Require FacterDB 2.x #176
Conversation
bastelfreak
force-pushed
the
facterdb2
branch
4 times, most recently
from
be4169e
to
09d6472
Compare
spec/rspec_puppet_facts_spec.rb
Outdated
| @@ -428,24 +428,25 @@ | |||
|
|
|||
| it 'returns supported OS' do | |||
| expect(subject.keys.sort).to eq [ | |||
| 'openbsd-5.7-amd64', | |||
| 'openbsd-7.5-amd64', | |||
There was a problem hiding this comment.
I wasn't 100% sure what's correct here. this passes now, but the filename is openbsd-7-x86_64.facts.
| ], | ||
| }, | ||
| { | ||
| "operatingsystem" => "Archlinux", | ||
| "operatingsystem" => "Gentoo", |
There was a problem hiding this comment.
I switched to Gentoo here because facter 4 dropped Archlinux support 😢
| end | ||
| end | ||
|
|
||
| context 'With a custom facterversion (3.3.2) in the options hash' do |
There was a problem hiding this comment.
this was a bit redundant so I dropped the tests
| { 'operatingsystem' => 'CentOS', 'operatingsystemrelease' => %w[7] }, | ||
| { 'operatingsystem' => 'OpenSuSE', 'operatingsystemrelease' => %w[42] }, | ||
| { 'operatingsystem' => 'CentOS', 'operatingsystemrelease' => %w[9] }, | ||
| { 'operatingsystem' => 'Debian', 'operatingsystemrelease' => %w[12] }, |
There was a problem hiding this comment.
getting this to pass with opensuse was ugly because sometimes it's OpenSuSE vs OpenSUSE and we don't have that many factsets, so I switched to Debian.
|
Marking this as backwards-incompatible. The new facterdb version dropped support for a huge number of legacy facter versions. Those were only used for Puppet 6 and older (which is EOL). |
|
I would like to merge and release voxpupuli/facterdb#364 first, so we can depend on that release here (2.1.0) instead of 2.0.1. |
bastelfreak
force-pushed
the
facterdb2
branch
3 times, most recently
from
d71538b
to
d75e427
Compare
No description provided.