work with symbolized strings

[bastelfreak]

No description provided.

[bastelfreak]

This contains #176

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (09cb9e9) to head (3fdbb05).
Report is 9 commits behind head on master.

❗ Current head 3fdbb05 differs from pull request most recent head f5fcdb5

Please upload reports for the commit f5fcdb5 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   95.34%   95.80%   +0.45%     
==========================================
  Files           2        2              
  Lines         172      167       -5     
==========================================
- Hits          164      160       -4     
+ Misses          8        7       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ekohl]

I'd be tempted to remove all symbol keys from facterdb and then do the .to_sym here in rspec-puppet-facts if requested. Any thoughts on that?

[bastelfreak]

I'd be tempted to remove all symbol keys from FacterDB and then do the .to_sym here in rspec-puppet-facts if requested. Any thoughts on that?

I considered that, but that would be another breaking change. I think with the current implementation it allows us to release it as an enhancement and then we can use the new rspec-puppet-facts + FacterDB version. Afterwards I would like to update FacterDB as you mentioned and also switch to strings by default in rspec-puppet-facts.

Basically:

• merge Make symbolize keys optional  facterdb#364 ✔️
• Release FacterDB 2.1 ✔️
• Merge Require FacterDB 2.x #176 + work with symbolized strings #175
• Release rspec-puppet-facts
• Merge Drop deprecated self.get_os_facts() facterdb#365 + Remove Legacy Facts facterdb#266 + Remove EoL CentOS 8 factsets facterdb#361 + Remove EoL CentOS 7 factsets facterdb#360 + Remove deprecated RedHat 7 facts facterdb#359
• Switch to strings by default in FacterDB
• Release FacterDB 3
• Update rspec-puppet-facts

[bastelfreak]

voxpupuli/facterdb#367 proove that this works always

[ekohl]

I was further looking at the changes and thought that moving to modern facts deserved its own PR for a cleaner history. #178 does that. I'd prefer to rebase this PR on top. As you can see, I already introduce the os_fact variable there, so it should be easy to modify.

[ekohl]

Did you intend to squash all your changes in a single commit?