Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Hash.to_h to construct a new hash #150

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Use Hash.to_h to construct a new hash #150

merged 1 commit into from
Jul 6, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jul 5, 2023

Also declares stringify_keys as a private API method.

bastelfreak
bastelfreak reviewed Jul 5, 2023
View reviewed changes
lib/rspec-puppet-facts.rb
@@ -179,8 +179,9 @@ def on_supported_os_implementation(opts = {})
os_facts_hash
end

# @api private
def stringify_keys(hash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know if that's used somewhere? should we mark it as breaking change? (I want to drop old rubies anyways)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should only be internal. And marking it with a comment doesn't mean it can't be called anymore, it's only a signal people consuming the API.

@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8d9370c) 94.93% compared to head (5e301c3) 94.93%.

❗ Current head 5e301c3 differs from pull request most recent head 59fb9bb. Consider uploading reports for the commit 59fb9bb to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files           2        2           
  Lines         158      158           
=======================================
  Hits          150      150           
  Misses          8        8
Impacted Files Coverage Δ
lib/rspec-puppet-facts.rb 98.03% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ekohl
Copy link
Member Author

ekohl commented Jul 5, 2023

Interesting that this behavior is different on Ruby 2.4 & 2.5. I think you finally have a good excuse to drop older versions because I do think this newer version is easier to read.

@bastelfreak
Copy link
Member

press the button on #149 :)

@ekohl ekohl mentioned this pull request Jul 5, 2023
Merged
@ekohl
Use Hash.to_h to construct a new hash
59fb9bb 
Also declares stringify_keys as a private API method.
@ekohl ekohl merged commit ca28a6a into voxpupuli:master Jul 6, 2023
@ekohl ekohl deleted the use-to_h branch July 6, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohl @bastelfreak