Merge pull request #150 from ekohl/use-to_h

Use Hash.to_h to construct a new hash
voxpupuli · Jul 6, 2023 · ca28a6a · ca28a6a
2 parents 555fd29 + 59fb9bb
commit ca28a6a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/rspec-puppet-facts.rb b/lib/rspec-puppet-facts.rb
@@ -179,8 +179,9 @@ def on_supported_os_implementation(opts = {})
     os_facts_hash
   end
 
+  # @api private
   def stringify_keys(hash)
-    Hash[hash.collect { |k,v| [k.to_s, v.is_a?(Hash) ? stringify_keys(v) : v] }]
+    hash.to_h { |k, v| [k.to_s, v.is_a?(Hash) ? stringify_keys(v) : v] }
   end
 
   # Register a custom fact that will be included in the facts hash.

diff --git a/spec/rspec_puppet_facts_spec.rb b/spec/rspec_puppet_facts_spec.rb
@@ -7,6 +7,10 @@
     'spec/fixtures/metadata.json'
   end
 
+  describe '.stringify_keys' do
+    it { expect(described_class.stringify_keys({ os: { family: 'RedHat' } })).to eq({ 'os' => { 'family' => 'RedHat' } }) }
+  end
+
   describe '.facter_version_for_puppet_version' do
     subject(:facter_version) do
       described_class.facter_version_for_puppet_version(puppet_version)