Add pylint configuration, fix linting issues, and update CI pipeline for Python #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kluge7
added
refactor
kluge7
force-pushed
the
463-task-address-pylint-linting-errors-in-codebase
branch
from
a58c285
to
377f8c1
Compare
Andeshog
requested changes
Sep 24, 2024
acoustics/acoustics_data_record/acoustics_data_record/acoustics_data_record_node.py
Outdated
Show resolved
Hide resolved
acoustics/acoustics_data_record/acoustics_data_record/acoustics_data_record_node.py
Outdated
Show resolved
Hide resolved
acoustics/acoustics_data_record/acoustics_data_record/acoustics_data_record_node.py
Outdated
Show resolved
Hide resolved
acoustics/acoustics_data_record/acoustics_data_record/acoustics_data_record_node.py
Outdated
Show resolved
Hide resolved
| self.get_logger().info("Acoustics PCB MCU IP: 10.0.0.111") | ||
| self.get_logger().info("Trying to connect...") | ||
|
|
||
| TeensyCommunicationUDP.init_communication(frequenciesOfInterest) | ||
| TeensyCommunicationUDP.init_communication(frequencies_of_interest) | ||
|
|
||
| self.get_logger().info("Sucsefully connected to Acoustics PCB MCU :D") | ||
|
|
||
| def data_update(self) -> None: |
There was a problem hiding this comment.
Sudden use of explicit output type. Should be consistent
|
|
||
| This method calls the fetch_data method from the TeensyCommunicationUDP class | ||
| to update the data. | ||
| """ | ||
| TeensyCommunicationUDP.fetch_data() | ||
|
|
||
| def data_publisher(self) -> None: |
There was a problem hiding this comment.
inconsistent use of -> None
There was a problem hiding this comment.
Now all functions should have a return type annotation (so all functions that dont return anything now have a -> None)
Andeshog
reviewed
Sep 25, 2024
acoustics/acoustics_interface/acoustics_interface/acoustics_interface_lib.py
Show resolved
Hide resolved
|
Just a head's up @kluge7 @Hallfred, there are a lot of deprecated typing. aliases, so using built-in types is now mostly favored (like Dict and List being deprecated for dict and list), check out https://docs.python.org/3/library/typing.html (and the Aliases to built-in types section in particular) |
Andeshog
approved these changes
Sep 27, 2024
kluge7
deleted the
463-task-address-pylint-linting-errors-in-codebase
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several improvements and refactorings related to code quality, linting, and CI pipeline updates. Please review the code carefully to ensure nothing broke during these changes.