Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Multiprocesses components #10

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Conversation

selankon
Copy link
Contributor

@selankon selankon commented Oct 10, 2024

It implements necessary components to render multiple elections on the same page.

It depends on vocdoni/ui-components#204

If the metadata of chained elections contains the RenderWith information, it get the elections to render together.

Changes:

  • Creates a layout to support renderwith and adapt the code an all the places to support this
  • Some layout fixes and unification
  • ConfirmVoteModal refactor to support new confirmation function parameters (now return a Record<string, FieldValues>. Is a dictionary of election ids with the field values)

Some considerations

  • Won't work with anonymous voting
  • Vote overwrite not tested but should work

And should work out of the box with all other chained process and Vocdoni features.

It also changes strict: false on tsconfig.json to be able to pass the lintern. For some reason this causes lintern issues on wagmi and rainbowkit configuration code, check ed3d28c for more info.

src/components/Process/Chained.tsx Outdated Show resolved Hide resolved
@elboletaire elboletaire marked this pull request as draft October 18, 2024 07:55
@elboletaire
Copy link
Member

Set as draft, since the dependency is a draft too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants