-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to accept multiquestion #204
Open
selankon
wants to merge
35
commits into
main
Choose a base branch
from
f/implement-multiprocess-questions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboletaire
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the wrongly imported components (using the package name instead of relative routes) could explain the context issues you told me about.
Edit: also, the tests should be passing 🥲
packages/chakra-components/src/components/Election/Questions/MultiElectionContext.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/MultiElectionConfirmation.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/MultiElectionQuestions.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/MultiElectionQuestions.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/MultiElectionQuestions.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/MultiElectionQuestions.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/VoteButton.tsx
Outdated
Show resolved
Hide resolved
Also fix a type
selankon
force-pushed
the
f/implement-multiprocess-questions
branch
from
October 17, 2024 06:56
a3bfe99
to
ef03ef0
Compare
elboletaire
requested changes
Oct 17, 2024
packages/chakra-components/src/components/Election/Questions/Form.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/Form.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/MultiElectionConfirmation.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/MultiElectionConfirmation.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/MultiElectionConfirmation.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/index.tsx
Outdated
Show resolved
Hide resolved
packages/chakra-components/src/components/Election/Questions/Form.tsx
Outdated
Show resolved
Hide resolved
Set as draft, since it's a WIP |
selankon
force-pushed
the
f/implement-multiprocess-questions
branch
from
October 22, 2024 10:21
b89b121
to
2c09335
Compare
selankon
force-pushed
the
f/implement-multiprocess-questions
branch
from
October 24, 2024 09:02
577884e
to
32181c9
Compare
selankon
force-pushed
the
f/implement-multiprocess-questions
branch
from
October 29, 2024 11:19
df32b57
to
c33691e
Compare
selankon
force-pushed
the
f/implement-multiprocess-questions
branch
from
October 30, 2024 08:13
c33691e
to
ee98753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances Chakra UI components to support multi-process pages. No breaking changes have been introduced; all components function as before. The
QuestionsFormProvider
is now extended to support multiple elections.This changes are used by vocdoni/ui-voting-page#10.
MultiProcess pages
UI components support rendering multiple elections on the same page. To enable multi-election support, wrap your election components as shown below:
The
renderWith
option inQuestionsFormProvider
is essential for rendering multiple elections, it includes the ids of the elections to be rendered excluding the root election id.Within the
QuestionsFormProvider
, you can use theuseQuestionsForm
hook to access the state of all elections along with other useful data:Key considerations
VoteButton
inside theQuestionsFormProvider
to ensure it properly reflects the election states across multiple elections. IfVoteButton
is outside this provider, it will only reflect the state of the root election (isAbleToVote
,voted
,voting
, etc.).Other inner changes consierations
Relevant changes on Questions form:
Record<string, FieldValues>
type, wherestring
is the election id. On this way, we can have multiple elections/questions on the same form.formId
. Useful to use specific id non related to the root election (now the form id contains the root election id)onSubmit
function can be added. This function is thought to programatically submit the form. For example, submiting the form with a default options when is disabled.form
tag is not inside of the chakra component anymoreVoted
component is modified to accept multiple nullifiers.