Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoscaler admission webhook #502

Merged
merged 14 commits into from
Jun 17, 2024
Merged

Conversation

kevinliu24
Copy link
Contributor

@kevinliu24 kevinliu24 commented May 3, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://nebula-graph.atlassian.net/browse/NGSR-107
#500

Description:

How do you solve it?

Added an admission webhook for autoscalar

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@kevinliu24 kevinliu24 changed the title feat: autoscaler webhook feat: add autoscaler webhook May 3, 2024
@kevinliu24 kevinliu24 self-assigned this May 3, 2024
@kevinliu24 kevinliu24 added the type/feature req Type: feature request label May 3, 2024
@kevinliu24 kevinliu24 changed the title feat: add autoscaler webhook feat: add autoscaler admission webhook May 3, 2024
Copy link
Contributor

@MegaByte875 MegaByte875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaByte875 MegaByte875 merged commit 9dc9688 into master Jun 17, 2024
2 checks passed
@wey-gu wey-gu deleted the autoscaler-webhook branch June 18, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature req Type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants