Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NA minReplica maxReplica validation #500

Closed
MegaByte875 opened this issue Apr 26, 2024 · 2 comments
Closed

NA minReplica maxReplica validation #500

MegaByte875 opened this issue Apr 26, 2024 · 2 comments
Assignees
@MegaByte875 @kevinliu24
Labels
affects/none PR/issue: this bug affects none version. process/fixed Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Milestone
v1.8.1

Comments

@MegaByte875
Copy link
Contributor

Please check the FAQ documentation before raising an issue

Describe the bug (required)

If minReplica > maxReplica , apply does not raise error, a few instances of graphd will cycle between being created and terminating state. Proposing adding a validation logic.

Your Environments (required)

  • OS: uname -a
  • Commit id (e.g. a3ffc7d8)

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context
@MegaByte875 MegaByte875 added the type/bug Type: something is unexpected label Apr 26, 2024
@MegaByte875 MegaByte875 self-assigned this Apr 26, 2024
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Apr 26, 2024
@wey-gu wey-gu mentioned this issue Apr 27, 2024
Open
@MegaByte875 MegaByte875 added this to the v1.8.1 milestone May 24, 2024
@kevinliu24
Copy link
Contributor

Design page:
https://nebula-graph.atlassian.net/wiki/spaces/TDEV/pages/149094404/Admissions+Webhook+for+Autoscaler+and+Passing+Cert+via+Sidecar

@kevinliu24 kevinliu24 mentioned this issue Jun 6, 2024
Merged
3 tasks
@MegaByte875
Copy link
Contributor Author

#502

@github-actions github-actions bot added the process/fixed Process of bug label Jun 17, 2024
@kevinliu24 kevinliu24 mentioned this issue Jun 19, 2024
Merged
3 tasks
@wey-gu wey-gu mentioned this issue Jun 22, 2024
Open
@kevinliu24 kevinliu24 mentioned this issue Jul 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MegaByte875 MegaByte875

@kevinliu24 kevinliu24

Labels
affects/none PR/issue: this bug affects none version. process/fixed Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Projects
None yet
Milestone
v1.8.1
Development

No branches or pull requests
2 participants
@MegaByte875 @kevinliu24