A minor overhaul #68
Merged
A minor overhaul #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. General docs cleanup.
…s when being decoded, make `Double` and `Float` accept integer values, use recommended APIs for translating between ByteBuffer and Data
… error handling. Make sure statements get finalized when errors occur. Use sqlite3_bind_blob64() and sqlite3_bind_text64() instead of the 32-bit ones. Simplify reading of blob data.
…dd set of async assertions. Make tests resilient against array index range violations. Handle blobs more sensibly instead of torturing Data. Get rid of lots of force-unwraps. Use "throws error" assertion instead of messy do/catch clauses. Avoid crashing if opening a DB fails. Use singleton thread pool and MTELG always.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 65.03% 65.60% +0.57%
==========================================
Files 8 9 +1
Lines 675 756 +81
==========================================
+ Hits 439 496 +57
- Misses 236 260 +24
|
…convenience methods. Factor out the `open()` implementation so the core part can be shared by the ELF and async versions. Don't leak sqlite3* handles if sqlite3_busy_handler() fails for some reason. Throw more specific errors from `open()`. Don't log at error level. Use the async version of NIOThreadPool.runIfActive() when possible.
…tion's async methods together.
…n_v2(), so there's no point in setting multithread mode as the default during compilation; use serialized as the default instead.
MahdiBM
approved these changes
May 3, 2024
…entation, plus omitting several APIs that aren't usable through this package anyway.
…y default (security hardening). Provide an initializer flag to override it if needed.
0xTim
requested changes
May 4, 2024
0xTim
reviewed
May 5, 2024
gwynne
changed the title
|
The dependents test will not pass without the fix to FluentSQLiteDriver to account for the extended result codes in the |
0xTim
approved these changes
May 10, 2024
| @@ -54,6 +55,33 @@ public struct SQLiteError: Error, CustomStringConvertible, LocalizedError { | |||
| case warning | |||
| case row | |||
| case done | |||
|
|
|||
| // SQLite "extended" result codes | |||
| case errorMissingCollatingSequence, errorRetry, errorMissingSnapshot | |||
There was a problem hiding this comment.
Urgh, we need a blanket ban on enums in the next major releases
There was a problem hiding this comment.
Or, you know, the core team could finally listen to people about the need to solve this problem 🤨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.9.0
Numerous improvements have been made to SQLiteNIO's functionality:
Strings,Floats, andDoubles via theSQLiteDataConvertiblepath (this primarily affects FluentSQLiteDriver and SQLiteKit), integer and real values are now converted to strings, and integer values are now converted to floats or doubles. Previously such conversions would be rejected.EventLoopFuture-based APIs now have explicitasynccounterparts, which in most cases saves at least a couple of excess thread hops. (This shows particular benefits inSQLiteKit- or rather, it will once Leverage improvements in SQLKit and SQLiteNIO sqlite-kit#108 lands.)SQLiteConnection.open().SQLiteConnection.open()now throws more useful, less generic errors.nilvalues would previously cause a crash, the failure is now handled gracefully.Sendablecorrectness has been implemented. In particular,SQLiteDatabaseis nowSendable.CSQLitetarget available to downstream packages, this should not affect users functionally, and may slightly improve performance and output binary size.SQLITE_DIRECTONLYby default; this can be changed by passingindirect: trueto theSQLiteCustomFunctioninitializer if needed.SQLiteErrornow recognizes and uses SQLite's more specific "extended" result codes.NIOThreadPool.singletonandMultiThreadedEventLoopGroup.singletonunless otherwise specified.