Leverage improvements in SQLKit and SQLiteNIO #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t we actually need, update CI, fix ExistentialAny usage, fix readme, update docs and logo
…ort for specifying JSON encoders and decoders, add support for new SQLKit functionality, default to singleton NIOThreadPool, modernize data encoder and decoder to handle data better and faster
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
===========================================
- Coverage 83.56% 70.56% -13.00%
===========================================
Files 7 7
Lines 219 316 +97
===========================================
+ Hits 183 223 +40
- Misses 36 93 +57
|
…is Sendable, support queryLogLevel, don't do extra thread hops in withSession()
gwynne
changed the title
|
Tests for this PR will fail until vapor/sqlite-nio#68 lands. |
…ving the conformance was source-breaking)
… @inlinable, fix a Sendability warning, add a missing doc comment.
0xTim
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.5.0
Several improvements:
Sendablecorrectness, including taking advantage of the improvements in A minor overhaul sqlite-nio#68ExistentialAnycompliancequeryLogLevelfunctionality is now fully implemented.NIOThreadPool.singletonandMultiThreadedEventLoopGroup.singletonunless otherwise specified.SQLiteDataEncoderandSQLiteDataDecoderare now slightly faster and behave more consistently.