-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parallelizeBuildables on iOS builds to improve build time #1724
Merged
Merged
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
a02742c
update react native to 0.65.2, working for android debug
kathaypacific 3e1dccc
update react and react native types, remove AppState.removeEventListe…
kathaypacific 88a0196
update test config for RN upgrade
kathaypacific b108d70
update test snapshots
kathaypacific 1acf18b
upgrade to RN 0.66.4, working for android debug
kathaypacific afad186
fix failing tests
kathaypacific 611bdfd
update types
kathaypacific 50021ad
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 04e97d9
disable lintVitalApptestRelease for now, to test CI
kathaypacific 4f4da66
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 7cb09ca
update snapshots in react components package
kathaypacific 3bc990e
update yarn audit known issues to fix vulnerabilities pipeline
kathaypacific 9f6c78b
remove lintOptions to observe the android lint error in CI again
kathaypacific 1353d4b
test ios upgrade
kathaypacific 1b23e22
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 1282a66
update hermes for RN 0.66
kathaypacific 26f8594
Fix build issue related to "error: could not build module 'Foundation'"
jeanregisser 418200d
update how we set EXCLUDED_ARCHS in podfile for M1 machines
kathaypacific a45e3fc
fix user_project pod install error
kathaypacific c4e601e
update correct checksum in podfile
kathaypacific 94fbac3
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 655d050
update outdated snapshot
kathaypacific 557e8f9
attempt to fix persistent build error by clearing yarn cache
kathaypacific 1363db1
add step in android CI to clean build cache, to avoid app:mergeExtDex…
kathaypacific d3f3282
update react-native-geth dependency
kathaypacific 216f62e
remove gradle cache clean for android e2e
kathaypacific 15f2d8d
remove explicit dependency on viewpager that was causing intermittent…
kathaypacific cf4c0a2
put back plaid package in android manifest
kathaypacific c6d0a1a
update kotlin version to fix plaid build error
kathaypacific 50c0681
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 18e0835
update snapshots from main
kathaypacific b67c9c8
exclude material dependency from detox for android build to stop inte…
kathaypacific 5daa86a
remove plaid import in android manifest to avoid runtime error 'nativ…
kathaypacific 4fee9d9
put back viewpager in android dependency
kathaypacific d4f82bc
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific fe6bfcf
upgrade some easy packages to use React-Core s.dependency to enable p…
kathaypacific 9668898
update react native contacts dependency hash
kathaypacific b63afc4
updated podfile.lock for react-native-contacts hash update
kathaypacific f2b078b
update async storage dependency
kathaypacific d52d6f8
update react-native-masked-view, patch rn keep-awake and rn exit-app …
kathaypacific c763bae
update podfile.lock
kathaypacific 92709c7
patch clevertap for xcode 12
kathaypacific a425d32
update lottie projects
kathaypacific c9fd185
upgrade react-native-splash-screen
kathaypacific dbba4e7
update patches
kathaypacific f7b122b
update tests
kathaypacific 611cacd
make splashscreen show fullscreen (bool instead of int) to fix androi…
kathaypacific 5271da8
repatch react-native-splash-screen
kathaypacific 9517006
upgrade react-native-camera
kathaypacific 2c1aa7b
correctly update rn splash screen android args
kathaypacific e8d4094
update react-native-keychain
kathaypacific 2efb71a
fix typescript error
kathaypacific 5a4d3b9
update podfile
kathaypacific 84c3b24
add e2e tests to branch to help test
kathaypacific 7b9faf7
update react-native-fs
kathaypacific 3de8d02
parallelise buildables on all ios apps
kathaypacific 7f27deb
fix yarn.lock
kathaypacific 63de0da
add patches for unmaintained libs
kathaypacific 5cc8084
update more libs, add temporary patch for react-native-blind-bls whil…
kathaypacific c930c4b
recreate temp react-native-blind-threshold-bls patch
kathaypacific 465c925
remove manually linked libs to resolve build warnings
kathaypacific 84d7871
update react-native-blind-threshold-bls and remove temporary patch
kathaypacific 35428c5
Merge branch 'main' into kathy/ios-parallelize-buildables
kathaypacific 8409c74
update to use https:// instead of git:// for dependency
kathaypacific f512f33
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific d96c31f
Merge branch 'kathy/upgrade-RN-65' into kathy/ios-parallelize-buildables
kathaypacific 0f8bc57
update test snapshot from main
kathaypacific 58ac906
update snapshot
kathaypacific 2b4f016
Merge branch 'main' into kathy/upgrade-RN-65
MuckT f6ea68d
test: record videos of failing tests
MuckT 58e4873
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 5ee7ac1
update snapshots from main
kathaypacific ba01b40
Merge branch 'kathy/upgrade-RN-65' into kathy/ios-parallelize-buildables
kathaypacific ee0e705
Merge branch 'main' into kathy/ios-parallelize-buildables
kathaypacific ef7f24f
test: set log level to trace for debugging in ci
MuckT c6421bd
test: tap to hide keyboard on android
MuckT ea7c808
Merge branch 'main' into kathy/ios-parallelize-buildables
MuckT b37fbef
Merge branch 'main' into kathy/ios-parallelize-buildables
MuckT dfeaf1b
add some logging to find android CI error
kathaypacific 04e93a4
remove workaround to test errors
kathaypacific 6db5822
add more logging
kathaypacific 77ab2aa
remove logging and workarounds, they didn't work
kathaypacific 57bc68a
Try hardcoded sleep instead of loop
jeanregisser 81b99ba
clean up various places
kathaypacific 092aa21
test: use system boot instead of wifi connection
MuckT 9007a2a
test: adjust waiting for device to boot command
MuckT 524c1ff
ci: wait for android device to boot
MuckT 56ba11c
Merge branch 'main' into kathy/ios-parallelize-buildables
MuckT efc7cf6
Merge branch 'main' into kathy/ios-parallelize-buildables
MuckT 4949195
Merge branch 'main' into kathy/ios-parallelize-buildables
kathaypacific 632c033
patch netinfo instead of upgrade
kathaypacific 3d6c2ad
navigate back to settings page after disconnecting d'app
kathaypacific 150ba90
Merge branch 'main' into kathy/ios-parallelize-buildables
kathaypacific File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -272,6 +272,7 @@ PLATFORMS | |
ruby | ||
universal-darwin-19 | ||
universal-darwin-20 | ||
universal-darwin-21 | ||
|
||
DEPENDENCIES | ||
cocoapods | ||
|
3 changes: 3 additions & 0 deletions
3
packages/mobile/__mocks__/@react-native-async-storage/async-storage.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import mock from '@react-native-async-storage/async-storage/jest/async-storage-mock' | ||
|
||
export default mock |
3 changes: 0 additions & 3 deletions
3
packages/mobile/__mocks__/@react-native-community/async-storage.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after apps are disconnected, the user is still on the Sessions screen but the next assertion for
ConnectedApplications/value
is on the Settings screen. because this assertion is in theafterAll
hook, the tests failed without being captured by the test reports or test artifacts. i think for correctness the command to navigate back to the settings screen should exist...(i also ran this test locally on the main branch, and it seems that the tests pass even though the app is still on the Sessions screen and the
ConnectedApplications/value
is not found :/ i'm not sure why it can pass, but the behaviour of disconnecting a connected app has not changed in this PR)