-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parallelizeBuildables on iOS builds to improve build time #1724
Conversation
…ner which is now deprecated and causing tests to fail
…ApptestRelease error from gradle cache
… duplicate class build error
@@ -323,6 +323,7 @@ export default WalletConnect = () => { | |||
await element(by.text('Connected Apps')).tap() | |||
await element(by.text('Tap to Disconnect')).tap() | |||
await element(by.text('Disconnect')).tap() | |||
await element(by.id('BackChevron')).tap() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after apps are disconnected, the user is still on the Sessions screen but the next assertion for ConnectedApplications/value
is on the Settings screen. because this assertion is in the afterAll
hook, the tests failed without being captured by the test reports or test artifacts. i think for correctness the command to navigate back to the settings screen should exist...
(i also ran this test locally on the main branch, and it seems that the tests pass even though the app is still on the Sessions screen and the ConnectedApplications/value
is not found :/ i'm not sure why it can pass, but the behaviour of disconnecting a connected app has not changed in this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! 💯 🚀
Description
The purpose of this PR is to enable us to use "dependency order" for the "build order". This is the default setting for xcode 13 and also since RN 0.62. The benefits include better build performance through more parallelisation and reduced dependency cycle errors.
To build in this way, dependencies need to require the
React-Core
pod instead ofReact
. For this reason, many dependencies needed to be updated. Where possible I have updated to the latest versions, some libs were deprecated so I have updated to the new recommended option.Of note:
New patches:
Other changes
Unlink react-native-geth and react-native-securerandom to resolve the below build warning. This was actually pretty straightforward, didn't cause any problems.
Tested
Manually
How others should test
A regression to see that app functionality hasn't been affected. e.g. QR scanning, app data persistence when force closing/opening the app.
Backwards compatibility
Yes