Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for valkey-benchmark negative path #1038

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Add test cases for valkey-benchmark negative path #1038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/integration/valkey-benchmark.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,20 @@ tags {"benchmark network external:skip logreqres:skip"} {
default_set_get_checks
}

test {benchmark: negative path} {
set wrong_host 127.0.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hostnames/IPs and ports seem pretty basic; was there a specific reason to test these, or was it due to an edge case encountered or a broader fix?

set wrong_port 6500
foreach e {valkeybenchmark valkeybenchmarkuri valkeybenchmarkuriuserpass} {
if {$e eq {valkeybenchmarkuriuserpass}} {
set cmd [valkeybenchmarkuriuserpass $wrong_host $wrong_port "default" pass "-c 5 -n 10 -t set"]
} else {
set cmd [$e $wrong_host $wrong_port "-c 5 -n 10 -t set"]
}
catch { exec {*}$cmd } res
assert_match "*Could not connect to server at*" $res
}
}

test {benchmark: connecting using URI set,get} {
set cmd [valkeybenchmarkuri $master_host $master_port "-c 5 -n 10 -t set,get"]
common_bench_setup $cmd
Expand Down
Loading