Add test cases for valkey-benchmark negative path #1038
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivshankar-Reddy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1038 +/- ##
============================================
+ Coverage 70.59% 70.63% +0.03%
============================================
Files 114 114
Lines 61670 61670
============================================
+ Hits 43538 43560 +22
+ Misses 18132 18110 -22 |
xbasel
reviewed
Nov 4, 2024
| @@ -37,6 +37,20 @@ tags {"benchmark network external:skip logreqres:skip"} { | |||
| default_set_get_checks | |||
| } | |||
|
|
|||
| test {benchmark: negative path} { | |||
| set wrong_host 127.0.0.0 | |||
There was a problem hiding this comment.
Hostnames/IPs and ports seem pretty basic; was there a specific reason to test these, or was it due to an edge case encountered or a broader fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the test case to check the wrong host case for valkey-benchmark.