CI corrections #60
Merged
CI corrections #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By only installing missing dependencies we get rid of notifications/warnings in Githubs build summary, like: `cmake 3.30.1 is already installed and up-to-date...` `openssl@3 3.3.1 is already installed and up-to-date...` Signed-off-by: Björn Svensson <[email protected]>
Includes build corrections for tests on Windows regarding missing timeval. Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
We can enable it back when we have formatted the code base, then it will be useful to run on PRs again. Signed-off-by: Björn Svensson <[email protected]>
michael-grunder
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can enable it back when we have formatted the code base via Improve formatting #53.
windowsIncludes build corrections for tests on Windows regarding missing timeval.
macosBy only installing missing dependencies we get rid of notifications/warnings in Githubs build summary, like:
cmake 3.30.1 is already installed and up-to-date...openssl@3 3.3.1 is already installed and up-to-date...Together with #59 the CI should start to be green, which makes it easier to deliver changes.
The macOS with SSL tests are still a bit flaky (also seen in hiredis).