Correcting source- and headerfile filtering in Makefile #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix issue after the RDMA feature delivery; filter out ssl source files again. - Filter out valkeycluster_ssl.h and only install it when build for SSL. Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
This was referenced Aug 1, 2024
Merged
|
Apologies, I totally missed the regression because we don't have all-green tests yet. |
|
No worries, I could see that and started to fix CI. Hopefully it will be better after #60 is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue after the RDMA feature delivery; filter out ssl source files again.
Issue found in CI.
Filter out valkeycluster_ssl.h and only install it when built with USE_SSL.
Additionally update CI to use SSL when verifying the installation.