Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Label Properties to 800-53 Rev 5 Groups #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brian-comply0
Copy link

Committer Notes

Added label properties to groups in NIST SP 800-53 r5, so that tools that honor the label property will have data to use.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@iMichaela
Copy link
Contributor

iMichaela commented Jul 10, 2024

@brian-comply0 - Thank you for splitting the proposed enhancements into two distinct PRs.
PLEASE NOTE- The PR needs to be submitted against develop or a feature-[issue] branch and not main branch.
I think this enhancement has great justification and aligns with the CPRT representation of 800-53 rev 5.1.1 (NIST's source of truth). I am waiting for the community to review and ensure their tools or automation process will not require updates they are against. I will give 2 weeks to the community to weigh in. It takes seconds to understand. We still need to work with our team to determine necessary testing @Wendell mentioned in the #268 discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants