Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added label properties to groups #269

Closed

Conversation

brian-comply0
Copy link

Committer Notes

Added label properties to groups in NIST SP 800-53 r4 and r5, so that tools that honor the label property will have data to use.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@brian-comply0
Copy link
Author

brian-comply0 commented Jul 1, 2024

This PR is in response to issue #268

@iMichaela
Copy link
Contributor

@brian-comply0 - Thank you for following your opened issue #268 so fast with this PR that is addressing it. It is something we, at NIST, dreamed for a long time: that the community provide solutions in addition to the issue created.
With that said:

  1. We do not push anything directly to main. The PR will have to be submitted against the develop branch and be part of a patch release.
  2. Before we get there, we need to make sure the issue NIST SP 800-53 r4 and r5 Missing Label Property in Group #268 is endorsed by others in the community as well and the feature you proposed (group label props) is needed by all community members or, at minimum, is not causing more work for them to update the parsers.

@brian-comply0 brian-comply0 changed the base branch from main to develop July 2, 2024 04:06
@brian-comply0
Copy link
Author

@iMichaela thank you for clarifying the target branch. I've updated it.

I fully respect the need to at least ensure this will not cause disruption and ideally hear if there is other interest.

@iMichaela
Copy link
Contributor

@iMichaela thank you for clarifying the target branch. I've updated it.

I fully respect the need to at least ensure this will not cause disruption and ideally hear if there is other interest.

Thank you @brian-comply0 . Let's give the community a little time to provide their perspective. Current week might not be the best to engage the community.

@brian-comply0
Copy link
Author

Per discussion with @iMichaela I am splitting this PR into two separate PRs, so that the Rev 4 and Rev 5 changes may be adjudicated independently.
Rev 5 is now in PR #271
Rev 4 is now in PR #272

Closing this PR unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants