Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Testing for winuitools #166

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: Testing for winuitools #166

merged 1 commit into from
Sep 12, 2023

Conversation

nickrandolph
Copy link
Contributor

Fixes: Canary build error on templates

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

WinUI detection not working meaning that WindowsIcon code not being generated

What is the new behavior?

WinUI detection working so WindowsIcon code is generated

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph
Copy link
Contributor Author

@mergify backport release/stable/1.1

@mergify
Copy link

mergify bot commented Sep 12, 2023 •
edited
Loading

backport release/stable/1.1

✅ Backports have been created

Youssef1313
Youssef1313 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question about part of the condition.

@nickrandolph nickrandolph mentioned this pull request Sep 12, 2023
Open
10 tasks
@nickrandolph nickrandolph merged commit fee0921 into main Sep 12, 2023
5 checks passed
@nickrandolph nickrandolph deleted the dev/nr/fixwinuidetection branch September 12, 2023 07:45
@mergify mergify bot mentioned this pull request Sep 12, 2023
Merged
nickrandolph added a commit that referenced this pull request Sep 12, 2023
@nickrandolph
Merge pull request #168 from unoplatform/mergify/bp/release/stable/1.…
4e0db5b 
…1/pr-166

fix: Testing for winuitools (backport #166)
@nickrandolph nickrandolph mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickrandolph @MartinZikmund @Youssef1313