Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor conditions for the _UnoResizetizerIsWindowsAppSdk property #167

Open
10 tasks
nickrandolph opened this issue Sep 12, 2023 · 0 comments
Open
10 tasks

Refactor conditions for the _UnoResizetizerIsWindowsAppSdk property #167

nickrandolph opened this issue Sep 12, 2023 · 0 comments
Labels
kind/bug Something isn't working priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@nickrandolph
Copy link
Contributor

Current behavior

As mentioned here there is a test for windows that will result in true for WPF (which probably isn't correct) and the test for ProjectReunion is no longer relevant

Expected behavior

Refactor to address the detection of windows and the removal of projectreunion

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?
@nickrandolph nickrandolph added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Sep 12, 2023
@nickrandolph nickrandolph mentioned this issue Sep 12, 2023
Merged
7 tasks
@nickrandolph nickrandolph added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed triage/untriaged Indicates an issue requires triaging or verification. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickrandolph