Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to remove the dependency to CommonServiceLocator package #53

Open
carldebilly opened this issue Jun 19, 2019 · 4 comments
Open

Need to remove the dependency to CommonServiceLocator package #53

carldebilly opened this issue Jun 19, 2019 · 4 comments

Comments

@carldebilly
Copy link
Member

Bug Report

Current behavior

Right now there's a strong dependency to CommonServiceLocator package defined
in the csproj:

https://github.com/nventive/Uno.Core/blob/5aecd4909faeacb522fb303cb100c9de14eabb06/src/Uno.Core/Uno.Core.csproj#L34

This dependency can conflict with higher level frameworks implementing the CommonServiceLocator of a more recent version.

Since Uno.Core is forcing a pretty old version, it's expected those conflicts can occurs.

Expected behavior

The code should be refactored to completely remove this dependency.

@MakanWG
Copy link
Contributor

MakanWG commented Feb 10, 2020

Just had the issue after referencing the latest version of MVVMLight which uses CommonServiceLocator 2.0.5 while Uno.Core still uses 1.3.0.
I downgraded MVVMLight to make it work. Is this the recommended solution until this item is adressed ? @MatFillion

@carldebilly
Copy link
Member Author

@MakanWG This reference could be removed totally. I think it's used for logging, but we can (and should) use something else for that.

@jeromelaban
Copy link
Member

It can be replaced, but it will make for a binary breaking change. We'll be doing a set of breaking changes like those along with the changes in AndroidX (which is going to force a whole set of other breaking changes)

@weitzhandler
Copy link
Member

Related: #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants