feat: attempt to resolve ILogger<T> directly from IServiceProvider first #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
reviewed
Apr 27, 2020
There was a problem hiding this comment.
Thanks for your contribution!
If you want to override the default behavior of the AmbientLogger, you should be able to set a ServiceLocator.Current before the loggers get initialized, that way you can provide your own implementation of ILoggerFactory and get the behavior you need.
Is that the original intent ?
|
As for the build failing, it's most likely related to the recent changes in the hosted agents. |
|
That worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
LogExtensionPoint, so that when anILogger<T>is requested, it'll first try to retrieve it first directly from the service provider.This way, we can keep the filtering, console/debug providers, min-log level and other logging setting to the upper app-level configuration setup using
ILogginBuilderwith generic-host or another third party tool.Related: #53