Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to latest CommonServiceLocator #68

Merged
merged 4 commits into from
Mar 31, 2020

Conversation

jeromelaban
Copy link
Member

@jeromelaban jeromelaban commented Mar 31, 2020

BREAKING CHANGE: The namespace of the ServiceLocator class has changed, and dependencies that rely on this type must adjust to this newer version.

To upgrade, replace all Microsoft.Practices.ServiceLocation by CommonServiceLocator.

@jeromelaban
Copy link
Member Author

/azp run

@jeromelaban jeromelaban force-pushed the dev/jela/servicelocator-update branch 4 times, most recently from 91290b9 to 554938d Compare March 31, 2020 16:20
BREAKING CHANGE: The namespace of the ServiceLocator class has changed, and dependencies that rely on this type must adjust to this newer version.

To upgrade, replace all `Microsoft.Practices.ServiceLocation` by `CommonServiceLocator`.
Copy link
Member

@carldebilly carldebilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to remove the dependency #53

@jeromelaban
Copy link
Member Author

Would prefer to remove the dependency #53

Removing the dependency implies moving everything that depends on it, and there are a lot of those (e.g. the .To<T>() extension).

@jeromelaban jeromelaban merged commit 44a7f0d into master Mar 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the dev/jela/servicelocator-update branch March 31, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants