Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaymentPlan add new status DRAFT #4336

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Oct 16, 2024

AB#215790: Adjust Payment Module to filter out the Payment Plan which are draft (old Target Population)

@pavlo-mk pavlo-mk added backend Changes in BE code work in progress Change doesn't need to be reviewed labels Oct 16, 2024
@pavlo-mk pavlo-mk self-assigned this Oct 16, 2024
@domdinicola
Copy link
Collaborator

@pavlo-mk I think this should go in the long term branch, no?
Unless it's just adding a filter then we can have in develop

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.61%. Comparing base (d5a4955) to head (6931322).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4336      +/-   ##
===========================================
- Coverage    77.89%   77.61%   -0.28%     
===========================================
  Files          937      938       +1     
  Lines        44353    44362       +9     
===========================================
- Hits         34548    34433     -115     
- Misses        9805     9929     +124     
Flag Coverage Δ
e2e 54.41% <88.88%> (-2.53%) ⬇️
unittests 76.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk changed the title WIP // PaymentPlan new status DRAFT PaymentPlan add new status DRAFT Oct 16, 2024
@pavlo-mk pavlo-mk marked this pull request as ready for review October 16, 2024 10:30
@pavlo-mk pavlo-mk removed the work in progress Change doesn't need to be reviewed label Oct 16, 2024
@pavlo-mk pavlo-mk marked this pull request as draft October 16, 2024 10:33
@pavlo-mk
Copy link
Contributor Author

will go to long term branch 🥇 📐

@pavlo-mk pavlo-mk added payment module work in progress Change doesn't need to be reviewed and removed work in progress Change doesn't need to be reviewed labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes in BE code payment module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants