Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clock constraints not affecting place_opt #836

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Dec 15, 2023

Addresses #820.
TLDR: Previously, top-level clock constraints weren't read until pre-CTS. Now, they are read pre-placement, so clock-aware placement can be performed.

Related PRs / Issues
#820

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew added this pull request to the merge queue Dec 15, 2023
Merged via the queue into master with commit 7aad633 Dec 15, 2023
3 checks passed
@harrisonliew harrisonliew deleted the clock_aware_top_place branch December 15, 2023 21:30
@harrisonliew
Copy link
Contributor

Closes #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants