-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch case when windows do not span entire sequence for pair coalescence stats #2989
Catch case when windows do not span entire sequence for pair coalescence stats #2989
Conversation
The issue was not passing Line 8463 in dcee409
which may be a bug? (Not sure what is intended here) Also would it be cleaner to move this option to the header? Line 1194 in dcee409
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
- Coverage 89.72% 89.72% -0.01%
==========================================
Files 29 29
Lines 31567 31567
Branches 6113 6113
==========================================
- Hits 28324 28322 -2
- Misses 1852 1853 +1
- Partials 1391 1392 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
702385c
to
ec568a0
Compare
This is ready whenever @jeromekelleher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better to be consistent with other code on where the exception is coming from all right.
Check for _tskit.LibraryError
ec568a0
to
2059859
Compare
Done-- there's a number of other places in test_lowlevel.py where |
Fixes issue reported here: #2986 (comment)