Access the left and right of an edge as an interval

[hyanwong]

Is this useful at all, or just an extra maintenance burden?

[benjeffery]

Don't think this is a bad idea - what code do you have where this is good and what is the alternative?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (d6b2303) to head (cfd5df0).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2531   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files          29       29           
  Lines       31578    31581    +3     
  Branches     6117     6118    +1     
=======================================
+ Hits        28333    28336    +3     
  Misses       1853     1853           
  Partials     1392     1392           

Flag	Coverage Δ
c-tests	86.55% <ø> (ø)
lwt-tests	80.78% <ø> (ø)
python-c-tests	88.98% <ø> (ø)
python-tests	99.01% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
python/tskit/trees.py	98.78% <100.00%> (+<0.01%)	⬆️

[hyanwong]

Don't think this is a bad idea - what code do you have where this is good and what is the alternative?

I needed to quickly check whether a tree covered a whole edge. tree.interval == edge.interval seems more comprehensible than tree.right == edge.right and tree.left == edge.left, but it's not exactly a priority!

[benjeffery]

Oh! That's a nice example. Seems like a good addition.

[benjeffery]

Converting this to a draft as it needs tests.

[hyanwong]

Yeah, meant to open as a draft, sorry.

[benjeffery]

@hyanwong Is this still something you want to try and merge?

[hyanwong]

I guess I might as well. The test will be trivial.

[benjeffery]

Ok, planning to get 0.5.9 out soon will add this PR to that.